Fix bundler2 CI build #3351
Merged
Fix bundler2 CI build #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
approved these changes
Mar 25, 2021
|
670fcc4 should fix the issue, once CI hits the point we see the load-error go away, I'll rebase to remove the debug commit and 🚢 |
670fcc4 to
a5b4840
Compare
a5b4840 to
ce0549a
Compare
|
Confirming build script fix is good, this should go green now - thanks @feelepxyz for the debug help! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pushed some breaking changes to the bundler2 implementation in a WIP branch in fd3d377 but all checks passed unexpectedly.
It seems CI isn't actually setting the
SUITE_NAMEproperly at present, so I've cherry picked a fix from my WIP to fix that asap.