Revert: Run Bundler v1 native helpers with explicit version #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
added a commit
that referenced
this pull request
Mar 5, 2021
This brings back this revert: #3222 We've wrapped bundler native helpers in `Bundler.with_original_env` to use the env before bundler was initialised in core. This removed the need to manually unset env vars like `GEM_HOME` and `GEM_PATH` which caused bundler to default git install to `/var/lib/gems/2.6.0/cache/bundler/git` when run in the parent container, where it doesn't have write permission. With this change the the bundle cache is written to the native helper folder/.bundle. Co-authored-by: Barry Gordon <brrygrdn@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #3196
We've run into some issues in production where bundle installs fail when fetching git dependencies as they try to write to a read-only file path:
We're rolling this back to put core in good state while we figure out an approach that will allow us to run multiple bundler versions.