Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cafile hack used for NPM 6 #11302

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Jan 14, 2025

What are you trying to accomplish?

Whilst working on adding the Bun package manager an issue was surfaced related to a custom cert used for NPM 6.

This PR removes the calfile from .npmrc.

See #11209

Anything you want to highlight for special attention from reviewers?

NPM 6 is no longer supported.

How will you know you've accomplished your goal?

No functional changes are observed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner January 14, 2025 17:04
@markhallen markhallen changed the title Remove cafile hack used for npm6 Remove cafile hack used for NPM 6 Jan 14, 2025
@markhallen markhallen merged commit b39f1f8 into main Jan 14, 2025
128 checks passed
@markhallen markhallen deleted the markhallen/remove-npm6-remnants branch January 14, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants