Revert "Improve error handling for missing dependency versions for github actions" #11289
+0
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub act…" This reverts commit 6c7a3b7.
abdulapopoola
approved these changes
Jan 13, 2025
| @@ -30,12 +30,6 @@ def parse | |||
| dependency_set += workfile_file_dependencies(file) | |||
| end | |||
|
|
|||
| dependencies_without_version = dependency_set.dependencies.select { |dep| dep.version.nil? } | |||
| unless dependencies_without_version.empty? | |||
| raise UnresolvableVersionError, | |||
There was a problem hiding this comment.
I think this is the only portion to be reverted but for clarity and simplicity; feel free to go ahead.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11144
Temporarily reverting as this causing more issues than it solves.