Handle DependencyFileNotParseable error on Updater.run #11288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ad0c6a to
94d2bed
Compare
php to 8.2 (#6506)94d2bed to
1906bda
Compare
markhallen
previously approved these changes
Jan 13, 2025
1906bda to
3b8bd40
Compare
d921dfd to
f226cef
Compare
amazimbe
commented
Jan 14, 2025
amazimbe
commented
Jan 14, 2025
jakecoffman
previously approved these changes
Jan 14, 2025
6f84548 to
94e1003
Compare
| return unless Experiments.enabled?(:record_update_job_unknown_error) | ||
|
|
||
| service.record_update_job_unknown_error( | ||
| error_type: T.must(error_details).fetch(:"error-type"), |
There was a problem hiding this comment.
any reason to record this as an unknown error again?
There was a problem hiding this comment.
Mostly because that's what's being done with the same error in this same file a few lines earlier. I'm not completely sure what the rules are for this categorisation so I just went with the precedent.
94e1003 to
1a21d40
Compare
randhircs
approved these changes
Jan 15, 2025
1a21d40 to
5038fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Handle a DependencyFileNotParseable error when running the Updater so that this error doesn't get propagated up the chain as an unknown error. It also won't appear in Sentry once it's been handled correctly.
We are already handling the exception on line https://github.com/dependabot/dependabot-core/blob/main/updater/lib/dependabot/update_files_command.rb#L27 and this just reapplies the same logic.
How will you know you've accomplished your goal?
The Sentry issue specified above should cease to appear.
Checklist