Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment to hint why we clean directories #11272

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

Nishnha
Copy link
Member

@Nishnha Nishnha commented Jan 10, 2025

What are you trying to accomplish?

Add a comment to hint why we clean the directories.
This serves as a code hint to anyone working on that section of code that they need to be careful about security implications.

Anything you want to highlight for special attention from reviewers?

Paths with ../.. are normalized in Core, so the Dependabot Core library cannot access directories outside of the project.

How will you know you've accomplished your goal?

The new code comment is present.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@Nishnha Nishnha requested a review from a team as a code owner January 10, 2025 18:02
@Nishnha Nishnha merged commit 768ddde into main Jan 10, 2025
128 checks passed
@Nishnha Nishnha deleted the nishnha/cleanpath-comment branch January 10, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants