-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BunLock FileParser #11268
Add BunLock FileParser #11268
Conversation
Co-authored-by: Ashcon Partovi <ashcon@partovi.ne>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @markhallen,
I noticed some differences in the structures of your Bun PRs. I thought it might follow a structure similar to the one used in the Docker Compose PR.
For example, it could look like this if we follow the same approach:
- lib/dependabot
- common (or shared)
- npm_and_yarn
- file_fetcher
...
- file_parser
....
- file_updater
...
- file_fetcher.rb
- file_parser.rb
- file_updater.rb
... so on
- npm_and_yarn.rb
- bun
- file_fetcher
...
- file_parser
....
- file_updater
...
- file_fetcher.rb
- file_parser.rb
- file_updater.rb
... so on
- bun.rb```
If you follow this structure, you won’t need to make any changes to npm_and_yarn
. Later, when we separate other package managers, we can adopt the same structure to create individual npm
, pnpm
, and yarn
folders. This will allow us to treat them as distinct ecosystems while retaining npm_and_yarn
for compatibility and managing deprecation/unsupported lifecycles.
Thanks @kbukum1
As discussed on Friday. This PR was put together before the change in approach. It was decided in the Friday standup that we proceed with these PR's as-is. We will then follow-up with a PR migrating to the new structure which will have the structure you have outlined above. This PR will then serve as an example for the migration of the other Javascript ecosystems.
The base branch was changed.
What are you trying to accomplish?
This PR adds the parser for
bun.lock
files. A later PR will add support for legacybun.lockb
files.bun
#6528Anything you want to highlight for special attention from reviewers?
For wider context you can check #11209 or #11248
The ultimate plan is to use a new structure for multiple Javascript ecosystems similar to #1862.
This PR was put together before the change in approach. It was decided that we proceed with these PR's as-is.
We will then follow-up with a PR migrating to the new structure. This migration PR will then serve as an example for the migration of the other Javascript ecosystems.
How will you know you've accomplished your goal?
The new specs should pass and the existing specs should be unimpacted.
Checklist