Type the workflow input as a number, not a string #11239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This input is a number, so although it's functioning fine currently as a string, by typing it properly as a number it removes a vector for string injection attacks if an attacker were to get escalated privileges on the repo. To be clear: this doesn't close an active vulnerability, but is just wise defense-in-depth. 🎩 💁♂️ to the person who pointed this out, you know who you are. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This input is a number, so although it's functioning fine currently as a string, by typing it properly as a number it removes a vector for string injection attacks if an attacker were to get escalated privileges on the repo.
To be clear: this doesn't close an active vulnerability. It adds defense-in-depth for the future.
🎩 💁♂️ to the person who pointed this out, you know who you are. 😁