expand pattern to filter out Microsoft.WebApplication.targets
#11236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13d8b1e to
50f019c
Compare
sebasgomez238
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd only filter out an imported project if its path was exactly
$(VSToolsPath)\WebApplications\Microsoft.WebApplication.targets, however in looking through the logs I've also seen instances of$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\WebApplications\Microsoft.WebApplication.targetsso I've simply expanded the pattern to match on any import with a file name ofMicrosoft.WebApplication.targets.While working on this I also found that if a test does fail, it's not reported in the log very well, so I've addressed that. With this additional fix, I found 2 unit tests that had some merge conflict artifacts. These tests were expected to fail, just not in the way that they were, so they've now been fixed to fail in the expected way again.