-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bundler deprecation unsupported check to use detected version #11222
Conversation
3d35f98
to
89bcb85
Compare
This PR is the fix for bundler based on the change made in the following PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look relatively straightforward, but I had some questions about the tests...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a good call with @kbukum1 and this seems relatively straightforward to me. And if I'm missing something and it goes sideways, it shouldn't break things too badly.
What are you trying to accomplish?
This PR updates the handling of deprecation and unsupported checks for Bundler by ensuring that
detected_version
is consistently used instead ofraw_version
.This change improves the accuracy of deprecation notices and resolves edge cases where
raw_version
is eithernil
or different from thedetected_version
. It also refines the notice generation and logging behavior to handle all scenarios correctly.Why?
Anything you want to highlight for special attention from reviewers?
unsupported?
and related methods was updated to handle cases whereraw_version
isnil
.detected_version
is deprecated or unsupported.raw_version
isnil
, deprecated, or different fromdetected_version
.NoticeHelpers
module was updated and thoroughly tested to ensure proper notice generation and logging behavior.How will you know you've accomplished your goal?
NoticeHelpers
and deprecation logic, pass successfully.detected_version
consistently, addressing any discrepancies.Checklist