Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds metric collection support for Docker #11217

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Adds metric collection support for Docker #11217

merged 1 commit into from
Jan 3, 2025

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 3, 2025 •
edited
Loading

What are you trying to accomplish?

Adds Metric collection for docker package manager

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 3, 2025
@github-actions github-actions bot added the L: docker Docker containers label Jan 3, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/docker-metric-collection branch 5 times, most recently from 34463c5 to 28abb65 Compare January 3, 2025 16:53
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 3, 2025 16:56
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 3, 2025 16:56
@sachin-sandhu sachin-sandhu marked this pull request as draft January 3, 2025 17:00
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/docker-metric-collection branch from 28abb65 to 3313ac5 Compare January 3, 2025 18:18
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 3, 2025 18:26
@kbukum1
Copy link
Contributor

kbukum1 commented Jan 3, 2025

@sachin-sandhu ,

Can you add a simple package manager spec that tests package manager version and deprecation/unsupported false?

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/docker-metric-collection branch from 3313ac5 to a6a5041 Compare January 3, 2025 18:56
@sachin-sandhu
Copy link
Contributor Author

sachin-sandhu commented Jan 3, 2025 •
edited
Loading

@sachin-sandhu ,

Can you add a simple package manager spec that tests package manager version and deprecation/unsupported false?

@kbukum1

Added new test cases for dep and unsupported
https://github.com/dependabot/dependabot-core/pull/11217/files#diff-447f34088ca8c781b6b0f50ce953f99a642dde33774ce0752ee6ead8149926ddR686

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/docker-metric-collection branch from a6a5041 to 2aed3e1 Compare January 3, 2025 18:58
kbukum1
kbukum1 reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to have coverage specs directly for package manager.

@kbukum1
Copy link
Contributor

kbukum1 commented Jan 3, 2025 •
edited
Loading

It will be great to have coverage specs directly for package manager.

Here is the example you can follow:

https://github.com/dependabot/dependabot-core/pull/11043/files#diff-dfd066f1a8a9ccff6522cbce6aa1bda1b8e4e59b433356131164aec7f273a2ac

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/docker-metric-collection branch from 2aed3e1 to c619c20 Compare January 3, 2025 21:14
kbukum1
kbukum1 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/docker-metric-collection branch from c619c20 to 2faa46b Compare January 3, 2025 22:18
@sachin-sandhu sachin-sandhu merged commit c9d550b into main Jan 3, 2025
57 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/docker-metric-collection branch January 3, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbukum1 kbukum1 kbukum1 approved these changes

Assignees

@sachin-sandhu sachin-sandhu

Labels
L: docker Docker containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachin-sandhu @kbukum1