Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] Only use the major.patch version to check deprecation status #11214

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Jan 3, 2025

What are you trying to accomplish?

Fix a bug where we compare a python version in major.minor.patch format against a list of python versions in major.minor format to check whether the version is deprecated. For example, 3.8.20 was coming up as not deprecated because we were comparing it against [3.8]. My solution is to only use the major.minor version to check deprecation status.

How will you know you've accomplished your goal?

I'll see a language deprecation warning, in the logs, for a repo with a python version greater than 3.8 but less than 3.9

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Jan 3, 2025
@amazimbe amazimbe marked this pull request as ready for review January 3, 2025 12:23
@amazimbe amazimbe requested a review from a team as a code owner January 3, 2025 12:23
@amazimbe amazimbe merged commit 39c9a56 into main Jan 3, 2025
60 checks passed
@amazimbe amazimbe deleted the amazimbe/fix-python-deprecation-version-match branch January 3, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants