Prevent forks from trying (and failing) to push latest images to GHCR #11213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
commented
Jan 3, 2025
| @@ -11,6 +11,7 @@ on: # yamllint disable-line rule:truthy | |||
| jobs: | |||
| date-version: | |||
| runs-on: ubuntu-latest | |||
| if: github.repository == 'dependabot/dependabot-core' | |||
There was a problem hiding this comment.
Because the subsequent push-updater-image job has needs: date-version, if this causes the date-version job to be skipped, then the push-updater-image job will also get skipped.
landongrindheim
approved these changes
Jan 3, 2025
I noticed on a recent commit to `main` on my personal fork that it's trying/failing to push images to GHCR due to permissions errors: https://github.com/jeffwidman/dependabot-core/actions/runs/12593801189 There's no point in forks doing that--they will never have the proper permissions to publish images to the real GitHub GHCR Dependabot image. We already prevent forks from trying to publish the base updater image here: https://github.com/dependabot/dependabot-core/blob/53178c5d340c7fcb171d5aec7e640d350f3f837c/.github/workflows/images-updater-core.yml#L14 We just forgot to also do it in this workflow for the final ecosystem images. So this rectifies that.
3d365bd to
7a4812b
Compare
|
Confirmed working by sync'ing the latest changes to my personal fork. 🎉 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on a recent commit to
mainon my personal fork that it's trying/failing to push images to GHCR due to permissions errors: https://github.com/jeffwidman/dependabot-core/actions/runs/12593801189There's no point in forks doing that--they will never have the proper permissions to publish images to the real GitHub GHCR Dependabot image.
We already prevent forks from trying to publish the base updater image here:
dependabot-core/.github/workflows/images-updater-core.yml
Line 14 in 53178c5
We just forgot to also do it in this workflow for the final ecosystem images.
So this rectifies that.