Selecting the correct requirement based on the given marker condition. #11204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Selecting the correct requirement based on the given marker condition.
When multiple requirements are present, the correct requirement should be selected based on the given marker condition.
Anything you want to highlight for special attention from reviewers?
Problem Being Solved:
In this PR
Title says : dependency version updated from 1.19.5 to 2.2.1
But file changes says: dependency version updated from 2.2.0 to 2.2.1
So there is a mismatch in title and actual pr changes.
How I am solving it:
Currently dependabot is always picking up the first dependency declaration from the requirements file.
But it should collect it based on the marker condition. (or the python_version used to compile)
For example:
if the compiling python_version is less than or equal to 2.6 then dependency version should be 1.0.4
else if the compiling python_version is greater than or equal to 2.7 then dependency version should be 1.3.0
I wrote RSpec to test the above 2 scenarios.
How will you know you've accomplished your goal?
RSpec and Dependabot Cli Run
Checklist