Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore semver condition is ignored when the version is nil in dependency #11156

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Dec 19, 2024

What are you trying to accomplish?

When dependabot is unable to extract the absolute version from the meta files fetched from the repository. Then it will extract the version from the requirement given.

This scenario will occur when package.lock.json is not present in the repository. And in package.json version is given as a constraint like ^1.0.0 instead of the absolute version. For this instance, dependabot extract the base version 1.0.0 as the current version to calculate the semver:major ignore condition.

Anything you want to highlight for special attention from reviewers?

I covered all the scenarios with RSpec and I have ran the cli to ensure latest_version_finder.rb taking this ignored condition while finding the latest version

How will you know you've accomplished your goal?

With RSpec and CLI Run

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit marked this pull request as draft December 19, 2024 14:35
@thavaahariharangit thavaahariharangit self-assigned this Dec 19, 2024
@thavaahariharangit thavaahariharangit marked this pull request as ready for review December 20, 2024 14:54
@thavaahariharangit thavaahariharangit merged commit e141a99 into main Dec 20, 2024
147 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/ignore-semver-condition-is-ignored-when-dep-version-not-present branch December 20, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants