-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore semver condition is ignored when the version is nil in dependency #11156
Merged
thavaahariharangit
merged 19 commits into
main
from
harry/ignore-semver-condition-is-ignored-when-dep-version-not-present
Dec 20, 2024
Merged
ignore semver condition is ignored when the version is nil in dependency #11156
thavaahariharangit
merged 19 commits into
main
from
harry/ignore-semver-condition-is-ignored-when-dep-version-not-present
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-dep-version-not-present
…n-dep-version-not-present
…n-dep-version-not-present
abdulapopoola
approved these changes
Dec 20, 2024
thavaahariharangit
deleted the
harry/ignore-semver-condition-is-ignored-when-dep-version-not-present
branch
December 20, 2024 16:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
When dependabot is unable to extract the absolute version from the meta files fetched from the repository. Then it will extract the version from the requirement given.
This scenario will occur when package.lock.json is not present in the repository. And in package.json version is given as a constraint like
^1.0.0
instead of the absolute version. For this instance, dependabot extract the base version1.0.0
as the current version to calculate the semver:major ignore condition.Anything you want to highlight for special attention from reviewers?
I covered all the scenarios with RSpec and I have ran the cli to ensure latest_version_finder.rb taking this ignored condition while finding the latest version
How will you know you've accomplished your goal?
With RSpec and CLI Run
Checklist