don't use transitive dependency version as top level version #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Dec 18, 2024
| // If the current version of the parent is less than the current version of the dependency | ||
| else if (CurrentVersion < currentVersionDependency) | ||
| { | ||
| return currentVersionDependency; |
There was a problem hiding this comment.
This was the real fix.
brettfo
commented
Dec 18, 2024
| @@ -3075,14 +3075,14 @@ await TestUpdateForProject("Some.Package", "12.0.1", "13.0.1", | |||
| public async Task UpdatingTransitiveDependencyWithNewSolverCanUpdateJustTheTopLevelPackage() | |||
| { | |||
| // we've been asked to explicitly update a transitive dependency, but we can solve it by updating the top-level package instead | |||
| await TestUpdateForProject("Transitive.Package", "1.0.0", "2.0.0", | |||
| await TestUpdateForProject("Transitive.Package", "7.0.0", "8.0.0", | |||
There was a problem hiding this comment.
Explicitly updated this test to cover the broken scenario.
brettfo
commented
Dec 18, 2024
| [InlineData(false)] | ||
| public async Task DependencyConflictsCanBeResolvedNewSharingDependency(bool useExistingSdks) | ||
| [Fact] | ||
| public async Task DependencyConflictsCanBeResolvedNewSharingDependency() |
There was a problem hiding this comment.
With the fix in this PR, this test started failing for an unrelated reason. Issue #11150 was filed and this test was made to follow a more common pattern to unblock the fix.
sebasgomez238
approved these changes
Dec 19, 2024
JamieMagee
approved these changes
Dec 19, 2024
22e29b1 to
8d82ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to update a top level dependency instead of pinning a transitive dependency, don't report the transitive version as a possible solution for the top level package.
This required an update to a test where the minimum version of a dependency doesn't exist. To get around this, the test was updated to use faked local packages with the correct versions. Issue #11150 was filed for the future work.