Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw appropriate error when failing to parse project file #11139

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Throw appropriate error when failing to parse project file #11139

merged 3 commits into from
Dec 17, 2024

Conversation

sebasgomez238
Copy link
Contributor

@sebasgomez238 sebasgomez238 commented Dec 16, 2024 •
edited
Loading

Adds try catch around project file XML parsing in the nuget updater and surfaces appropriate error type.

@sebasgomez238 sebasgomez238 requested a review from a team as a code owner December 16, 2024 20:51
@randhircs randhircs force-pushed the users/segomez/invalid-xml-nuget-fix branch from 3aaa87b to e101726 Compare December 17, 2024 16:43
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 17, 2024
@randhircs randhircs force-pushed the users/segomez/invalid-xml-nuget-fix branch from e101726 to 3d478ed Compare December 17, 2024 17:21
@sebasgomez238 sebasgomez238 marked this pull request as draft December 17, 2024 17:49
@sebasgomez238 sebasgomez238 marked this pull request as ready for review December 17, 2024 18:16
@randhircs randhircs merged commit 5512ee3 into main Dec 17, 2024
88 of 90 checks passed
@randhircs randhircs deleted the users/segomez/invalid-xml-nuget-fix branch December 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@brettfo brettfo brettfo approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebasgomez238 @brettfo @JamieMagee @randhircs