Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If overridden file exists, then process it and find the missing key values from base file. #11137

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Dec 16, 2024

What are you trying to accomplish?

When the config file is overridden, the code should process it and find the missing key values from the base file.

Anything you want to highlight for special attention from reviewers?

Ref : https://developer.hashicorp.com/terraform/language/files/override

How will you know you've accomplished your goal?

Wrote an rspec test to check if the overridden module does not include the source. And ensured that when there is a property present in both then overridden value is present in the dependency set.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner December 16, 2024 15:24
@github-actions github-actions bot added the L: terraform Terraform packages label Dec 16, 2024
@@ -58,6 +58,14 @@ def ecosystem
def parse_terraform_files(dependency_set)
terraform_files.each do |file|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up; can we add Sorbet typing to this file please?

@thavaahariharangit thavaahariharangit merged commit 3f1e9f8 into main Dec 16, 2024
57 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/terraform-overridden-config branch December 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: terraform Terraform packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants