Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump poetry version from 1.8.3 to 1.8.5 #11107

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

noorul
Copy link
Contributor

@noorul noorul commented Dec 12, 2024

PR #11079 is failing because of grouping. Not sure grouping is mandatory.

@noorul
Copy link
Contributor Author

noorul commented Dec 12, 2024

I think for the smoke tests to pass we need to merge dependabot/smoke-tests#240 first. Or is there a way to test them together?

@jeffwidman
Copy link
Member

I think for the smoke tests to pass we need to merge dependabot/smoke-tests#240 first.

Probably.

Or is there a way to test them together?

For testing purposes, you can point the smoke tests workflow file at a specific branch, but then you'll need to be sure that the final PR doesn't include that custom branch name.

@jeffwidman
Copy link
Member

@jeffwidman jeffwidman merged commit 83a4aab into dependabot:main Dec 12, 2024
44 checks passed
jeffwidman added a commit that referenced this pull request Dec 14, 2024
We grouped the Python PR's to avoid noise. However, what I've observed in practice is we (and our users) care more about staying up to date on the package managers and not so much if the internal libraries used in our helpers stay up to date.

So by breaking the package managers themselves out as distinct groups, it allows us to quickly move forward on those, without getting blocked if there's a breaking change in a minor helper library.

Here's an example of exactly this problem:
* #11107 (comment)
jeffwidman added a commit that referenced this pull request Jan 3, 2025
We grouped the Python PR's to avoid noise. However, what I've observed in practice is we (and our users) care more about staying up to date on the package managers and not so much if the internal libraries used in our helpers stay up to date.

So by breaking the package managers themselves out as distinct groups, it allows us to quickly move forward on those, without getting blocked if there's a breaking change in a minor helper library.

Here's an example of exactly this problem:
* #11107 (comment)
jeffwidman added a commit that referenced this pull request Jan 3, 2025
We grouped the Python PR's to avoid noise. However, what I've observed in practice is we (and our users) care more about staying up to date on the package managers and not so much if the internal libraries used in our helpers stay up to date.

So by breaking the package managers themselves out as distinct groups, it allows us to quickly move forward on those, without getting blocked if there's a breaking change in a minor helper library.

Here's an example of exactly this problem:
* #11107 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants