Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elevate formatting issues to build failure #11098

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Dec 11, 2024

The NuGet updater already enforces code formatting as a CI check, but this ensures the formatting failures are raised as errors in the build and appear in the IDE. This makes finding and fixing them much easier so a CI cycle isn't wasted.

This PR contains a temporary commit that introduces a formatting error to verify the CI fails as expected. Onec verified this commit will be removed.
Temporary commit resulted in the expected build error in CI.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 11, 2024
@brettfo brettfo force-pushed the dev/brettfo/nuget-enforce-formatting branch 2 times, most recently from 9265b78 to c659856 Compare December 11, 2024 18:41
@brettfo brettfo marked this pull request as ready for review December 19, 2024 18:56
@brettfo brettfo requested a review from a team as a code owner December 19, 2024 18:56
@brettfo brettfo force-pushed the dev/brettfo/nuget-enforce-formatting branch from c659856 to 0329e74 Compare December 19, 2024 18:56
@randhircs randhircs force-pushed the dev/brettfo/nuget-enforce-formatting branch from 0329e74 to 44a4a48 Compare December 19, 2024 20:45
@randhircs randhircs merged commit 945bb18 into main Dec 19, 2024
70 checks passed
@randhircs randhircs deleted the dev/brettfo/nuget-enforce-formatting branch December 19, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants