Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet ecosystem metric collection #11097

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Dotnet ecosystem metric collection #11097

merged 1 commit into from
Dec 12, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Dec 11, 2024 •
edited
Loading

What are you trying to accomplish?

Dotnet ecosystem metric collection

Collects following:

Nuget package manager version information
Dotnet languages C#, F#, VB metric along with targeted framework version
Ecosystem metric

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Dec 11, 2024
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 11, 2024
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dotnet-ecosystem-metric branch 3 times, most recently from 47fc3fb to 8166028 Compare December 11, 2024 18:08
@sachin-sandhu sachin-sandhu changed the title dotnet ecosystem metric collection Dotnet ecosystem metric collection Dec 11, 2024
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dotnet-ecosystem-metric branch from 8166028 to bba399f Compare December 11, 2024 18:11
@sachin-sandhu sachin-sandhu marked this pull request as ready for review December 11, 2024 18:13
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner December 11, 2024 18:13
@sachin-sandhu sachin-sandhu requested a review from a team December 11, 2024 18:14
randhircs
randhircs approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me looks good.

@sachin-sandhu sachin-sandhu removed the request for review from brettfo December 12, 2024 16:23
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dotnet-ecosystem-metric branch from bba399f to 9dee760 Compare December 12, 2024 17:00
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dotnet-ecosystem-metric branch from 9dee760 to 042851d Compare December 12, 2024 17:05
@sachin-sandhu sachin-sandhu merged commit 16adecd into main Dec 12, 2024
70 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/dotnet-ecosystem-metric branch December 12, 2024 17:53
@sachin-sandhu sachin-sandhu mentioned this pull request Jan 9, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhircs randhircs randhircs approved these changes

@amazimbe amazimbe amazimbe approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees

@sachin-sandhu sachin-sandhu

Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sachin-sandhu @JamieMagee @amazimbe @randhircs