Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing test for scenario #11087

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Dec 9, 2024

When asked if we supported a certain scenario, I couldn't find a test that did exactly this, but it is supported so this just adds a test.

The scenario is the <PackageReference> element existing in a non-standard .targets file with the Version property as a sub-element.

@brettfo brettfo requested a review from a team as a code owner December 9, 2024 19:26
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 9, 2024
@brettfo brettfo force-pushed the dev/brettfo/nuget-add-test branch from 97f5fd4 to db004ac Compare December 9, 2024 20:52
@thavaahariharangit thavaahariharangit merged commit ad6a02f into main Dec 10, 2024
70 checks passed
@thavaahariharangit thavaahariharangit deleted the dev/brettfo/nuget-add-test branch December 10, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants