Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old update checker and stale code #11076

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Dec 6, 2024

The experiment nuget_native_analysis has been active for several weeks with no major issues requiring it be turned off. I think it's time to call this code good.

Back in PR #10025 the new native analysis was all placed behind files and types with the native_ and Native prefixes. This PR removes the old code and removes that separator prefix because it's no longer used. I also audited a bunch of helper files and functions and cleaned those out, as well.

Future work:

  • Remove the experiment flag from the internal repos.
  • Remove the experiment flag from the smoke tests.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 6, 2024
@brettfo brettfo force-pushed the dev/brettfo/nuget-remove-old-update-checker branch 3 times, most recently from abe76c2 to 1881e3d Compare December 7, 2024 01:01
@brettfo brettfo force-pushed the dev/brettfo/nuget-remove-old-update-checker branch from 1881e3d to 5edc7a1 Compare December 7, 2024 01:01
@brettfo brettfo marked this pull request as ready for review December 7, 2024 01:20
@brettfo brettfo requested a review from a team as a code owner December 7, 2024 01:20
@randhircs randhircs merged commit fa9831f into main Dec 9, 2024
72 checks passed
@randhircs randhircs deleted the dev/brettfo/nuget-remove-old-update-checker branch December 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants