detect byte order mark in YAML and report error #11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d98e76e to
6a08c88
Compare
ByAgenT
approved these changes
Dec 6, 2024
honeyankit
approved these changes
Dec 6, 2024
6a08c88 to
d851414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a YAML file was saved with the encoding "UTF-8 with BOM" and parsed, only the first property will be reported, ignoring the rest of the file and ultimately resulting in no images found and nothing updatable.
This PR explicitly detects the byte order mark and reports
DependencyFileNotParseablewith a message so the user can correct it.Bug was found during internal investigations.