make directory crawling unit-testable #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a659dff to
260f0e3
Compare
260f0e3 to
daf2e65
Compare
sebasgomez238
approved these changes
Dec 6, 2024
184be12 to
87c2c05
Compare
e25fe4d to
917b88f
Compare
917b88f to
6a944b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the eventual end-to-end C# NuGet updater, a PowerShell script is used to crawl the directories for
global.jsonfiles for SDK installation prior to the job running. This PR makes that behavior testable and fixes a bug where this logic would previously throw when trying to navigate past the update root directory.