Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary log messages #11065

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Dec 5, 2024

Clean up log messages added in #11055.

Originally the log messages were to debug why a file generated during fetch_files wasn't present for the subsequent call to update_files. I've since learned that in certain instances, update jobs can run those two commands in separate containers with no shared filesystem.

The fix to re-run discovery if needed is still the correct choice, so this only backs off the logging.

Recent telemetry shows that re-running the discovery has fixed the original issue.

@brettfo brettfo requested a review from a team as a code owner December 5, 2024 22:16
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 5, 2024
@randhircs randhircs force-pushed the dev/brettfo/nuget-clean-logs branch from 1c847f0 to da69715 Compare December 6, 2024 13:01
@randhircs randhircs merged commit fa2987c into main Dec 6, 2024
70 checks passed
@randhircs randhircs deleted the dev/brettfo/nuget-clean-logs branch December 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants