filter out invalid requirement strings from array #11049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1186074 to
c81f13f
Compare
sebasgomez238
approved these changes
Dec 3, 2024
c81f13f to
926785f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing package update analysis, it's possible for invalid requirement strings to be passed in to the
IgnoredVersionselement. This can happen if the user manually added a version to the ignore list, but mistyped it.The fix is to change the
RequirementJSON converter toRequirement[]and filter out invalid values.All changes to
AnalyzeWorker.csare to make unit testing easier so theDeserialize...method can be strongly-typed and directly called.Issue found during a manual audit of error logs.