Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retries interval to registry client #11048

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken commented Dec 3, 2024

What are you trying to accomplish?

Adding a retry interval to registry client Excon GET requests to better handle transient socket EOF errors affecting Maven and Terraform dependency updates by spacing out retry attempts.

Anything you want to highlight for special attention from reviewers?

The change spaces out retry attempts by 5 seconds, working with Excon's default of 4 retries for idempotent requests. This should help prevent rapid consecutive failures while still maintaining the existing retry behavior.

How will you know you've accomplished your goal?

  • Error rate monitoring shows reduction in EOFError failures
  • Failbot metrics confirm retried requests succeed

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@robaiken robaiken self-assigned this Dec 3, 2024
@robaiken robaiken requested a review from a team as a code owner December 3, 2024 16:02
@robaiken robaiken marked this pull request as draft December 3, 2024 16:03
@robaiken robaiken force-pushed the robaiken/add-registry-client-retries branch from 70d2ac5 to ffea783 Compare December 3, 2024 16:05
@robaiken robaiken added the F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter label Dec 3, 2024
@robaiken robaiken force-pushed the robaiken/add-registry-client-retries branch 2 times, most recently from 65b46ab to 1b76372 Compare December 3, 2024 16:15
@robaiken robaiken changed the title Adding retries to registry client Adding retries interval to registry client Dec 4, 2024
@robaiken robaiken marked this pull request as ready for review December 4, 2024 13:52
@robaiken robaiken force-pushed the robaiken/add-registry-client-retries branch from e201b82 to b6f4c93 Compare December 4, 2024 14:18
@robaiken robaiken merged commit fc28e3c into main Dec 4, 2024
127 checks passed
@robaiken robaiken deleted the robaiken/add-registry-client-retries branch December 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: noise related to Dependabot being noisy, or initiatives to make Dependabot quieter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants