Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align C# log messages with Ruby #11044

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Dec 2, 2024

Replace logger.Log(...) with logger.Info(...), etc. where the formatting matches the messages produced by the Ruby logger call Dependabot.logger.info(...). This is to ensure consistent log messages, no matter what code produced it.

There were also a few instances of Console.WriteLine that were replaced with the appropriate logger call.

@brettfo brettfo requested a review from a team as a code owner December 2, 2024 23:02
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 2, 2024
@brettfo brettfo force-pushed the dev/brettfo/nuget-log-messages branch from 8ce3122 to 9f2da4a Compare December 2, 2024 23:04
@brettfo brettfo force-pushed the dev/brettfo/nuget-log-messages branch 2 times, most recently from 50480ff to 010062f Compare December 3, 2024 20:52
@randhircs randhircs force-pushed the dev/brettfo/nuget-log-messages branch from 010062f to 60360a7 Compare December 3, 2024 23:16
@randhircs randhircs enabled auto-merge December 3, 2024 23:53
@randhircs randhircs disabled auto-merge December 3, 2024 23:53
@randhircs randhircs merged commit c98a329 into main Dec 4, 2024
70 checks passed
@randhircs randhircs deleted the dev/brettfo/nuget-log-messages branch December 4, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants