Reorders package managers for python ecosystem metric collection #11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,12 +93,12 @@ def package_manager | |||
| def detected_package_manager | |||
| setup_python_environment if Dependabot::Experiments.enabled?(:enable_file_parser_python_local) | |||
|
|
|||
| return PipenvPackageManager.new(T.must(detect_pipenv_version)) if detect_pipenv_version | |||
|
|
|||
| return PoetryPackageManager.new(T.must(detect_poetry_version)) if detect_poetry_version | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
for python , we are evaluating package managers based on the lock file names generated, i.e. poetry.lock , requirements.txt etc,
dea8139 to
a717d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We are not able to see
pipenvpackage manager in metric collection, experimenting if reordering package manager as perupdate checkerresolves this issue.Adds more telemetry data to verify python version that is coming up in metric.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist