-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics Collection for Composer Ecosystem: Package Manager and Language Details #11025
Add Metrics Collection for Composer Ecosystem: Package Manager and Language Details #11025
Conversation
) | ||
end | ||
|
||
sig { returns(T.nilable(Ecosystem::VersionManager)) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to return N/A in case this is also not defined instead of nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a instance object, It will be hard to return N/A
in case if we don't have version. If we want to do that we need to return T.any(String, Ecosystem::VersionManager), 2 different types which will make it more complicated.
What are you trying to accomplish?
This PR enhances metrics collection for the Composer ecosystem by adding the following details:
Why:
These additions improve observability and provide detailed insights for Composer ecosystem metrics, helping to better understand versioning and compatibility issues.
What issues does this affect or fix?
N/A
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist