-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Language Name, Version, and Requirements for npm
, pnpm
, and yarn
#11017
Store Language Name, Version, and Requirements for npm
, pnpm
, and yarn
#11017
Conversation
450537d
to
27a7269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little hard to see the functional changes amid all of the added logging. In the future if you're adding logging to otherwise untouched code, can you bundle it as a separate change/PR?
Re: the new logging - much of the added Dependabot::Logger.info
output looks like debug information which can get noisy if it's always written to logging. Would it make sense to use Dependabot::Logger.debug
to keep noise down in prod logs but still make it easy to toggle on when debugging?
@jonabc I also wanted to note that, in our investigations, errors related to run commands are often the hardest to diagnose because we lack proper logging for them. That’s why I’ve focused on adding logging, particularly around command execution. Let me know if you think this could be approached differently! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough practical experience with dependabot-core to know whether my previous comments are valid. I'm still a little uncomfortable with the change but 🤷 the functional changes seem small and tested
What are you trying to accomplish?
This PR adds functionality to detect and include the language name (
Node.js
) and its version fornpm
,pnpm
, andyarn
package managers.Why?
Node.js
) by usingnode -v
to fetch the version directly.This change improves Dependabot's ability to work with JavaScript projects by explicitly detecting and documenting Node.js as the runtime language and its version.
Anything you want to highlight for special attention from reviewers?
node -v
command to fetch the Node.js version at runtime. This approach is simple, reliable, and avoids relying on indirect metadata (e.g.,volta
orengines.node
).npm
,pnpm
, andyarn
) work seamlessly with this addition.How will you know you've accomplished your goal?
npm
,pnpm
, andyarn
projects confirms the correct Node.js version is detected.Checklist