Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source_url in Maven::UpdaterChecker::RequirementsUpdater can be nil #10876

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

JamieMagee
Copy link
Contributor

What are you trying to accomplish?

We're seeing the following Sorbet errors:

Parameter 'source_url': Expected type String, got type NilClass
Caller: /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/sorbet-runtime-0.5.11577/lib/types/private/methods/call_validation.rb:133
Definition: /home/dependabot/maven/lib/dependabot/maven/update_checker/requirements_updater.rb:34 (Dependabot::Maven::UpdateChecker::RequirementsUpdater#initialize)

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner October 31, 2024 22:26
@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Oct 31, 2024
@abdulapopoola abdulapopoola merged commit 7289d64 into main Oct 31, 2024
59 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/maven-source-url branch October 31, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: java:maven Maven packages via Maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants