Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Registry Upgrade #10855

Merged
merged 9 commits into from
Nov 1, 2024

Conversation

lewis-strong
Copy link
Contributor

@lewis-strong lewis-strong commented Oct 28, 2024

What are you trying to accomplish?

Fix for pagination on quay.io as this is currently not working

#10347

https://github.com/deitch/docker_registry2/releases/tag/v1.18.2

Fix introduced at 1.18.2 as per above tag

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

thomas-riccardi and others added 4 commits September 10, 2024 18:17
…e fix

also manually reported to Gemfile.lock files
Signed-off-by: Lewis Strong <lewis.strong@qodea.com>
@lewis-strong lewis-strong marked this pull request as ready for review October 28, 2024 09:54
@lewis-strong lewis-strong requested a review from a team as a code owner October 28, 2024 09:54
@lewis-strong lewis-strong changed the title Docker Registry Docker Registry Upgrade Oct 28, 2024
@lewis-strong
Copy link
Contributor Author

@yeikel - Are you able to review this PR please?

@targylyen
Copy link

@lewis-strong I can't wait to see that being merged and released. 😄

@thomas-riccardi
Copy link
Contributor

does anyone knows how to get a dependabot maintainer to review PRs?
cc @dependabot/maintainers (does this work?)

@lewis-strong
Copy link
Contributor Author

@JamieMagee - I've rebased a number of times to keep the PR up to date, on the latest rebase though there's a check which appears to be hung and I can't cancel or rerun.

Is this something you can help with?

@lewis-strong
Copy link
Contributor Author

@JamieMagee - I've rebased a number of times to keep the PR up to date, on the latest rebase though there's a check which appears to be hung and I can't cancel or rerun.

Is this something you can help with?

Rebased again and all checks passing again.

Can we get this merged? @JamieMagee

@JamieMagee
Copy link
Contributor

@lewis-strong Unfortunately, I don't have merge permissions in this repo. Let me see if I can get someone to merge.

@thavaahariharangit thavaahariharangit merged commit 3711a98 into dependabot:main Nov 1, 2024
107 checks passed
@lewis-strong lewis-strong deleted the docker-registry branch November 1, 2024 18:01
@lewis-strong
Copy link
Contributor Author

Thanks All! 🥳

@targylyen
Copy link

Thank you guys!

@JamieMagee
Copy link
Contributor

@lewis-strong this is causing errors. Might need to roll this back.

TypeError: no implicit conversion of nil into Array
  from dependabot-updater/vendor/ruby/3.3.0/gems/docker_registry2-1.18.2/lib/registry/registry.rb:101:in `+'
  from dependabot-updater/vendor/ruby/3.3.0/gems/docker_registry2-1.18.2/lib/registry/registry.rb:101:in `tags'
  from docker/lib/dependabot/docker/update_checker.rb:198:in `tags_from_registry'

@DashaBochkar
Copy link

Thanks

@lewis-strong
Copy link
Contributor Author

@lewis-strong this is causing errors. Might need to roll this back.

TypeError: no implicit conversion of nil into Array
  from dependabot-updater/vendor/ruby/3.3.0/gems/docker_registry2-1.18.2/lib/registry/registry.rb:101:in `+'
  from dependabot-updater/vendor/ruby/3.3.0/gems/docker_registry2-1.18.2/lib/registry/registry.rb:101:in `tags'
  from docker/lib/dependabot/docker/update_checker.rb:198:in `tags_from_registry'

@JamieMagee was this an unrelated issue which has now been fixed? I can see Quay pagination is now working in dependabot and it's prompted me with an update this morning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants