-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Registry Upgrade #10855
Docker Registry Upgrade #10855
Conversation
…er registry pagination Fix dependabot#10347, cf deitch/docker_registry2#106 Updates `docker_registry2` from 1.18.0 to 1.18.2 Commits * [`b830597`](deitch/docker_registry2@b830597) bump 1.18.2 ([dependabot#108](https://redirect.github.com/deitch/docker_registry2/issues/108)) * [`2915d80`](deitch/docker_registry2@2915d80) Fix pagination for tags list pagination for quay.io & registry.access.redhat.... * [`2071379`](deitch/docker_registry2@2071379) remove gemfile.lock from gitignore and commit to git ([dependabot#105](https://redirect.github.com/deitch/docker_registry2/issues/105)) * [`c33e9f5`](deitch/docker_registry2@c33e9f5) v1.18.1 ([dependabot#104](https://redirect.github.com/deitch/docker_registry2/issues/104)) * [`4d4b968`](deitch/docker_registry2@4d4b968) Smartly join URLs ([dependabot#101](https://redirect.github.com/deitch/docker_registry2/issues/101)) * [`d11771a`](deitch/docker_registry2@d11771a) Enhancement of rubocop and tests configs ([dependabot#103](https://redirect.github.com/deitch/docker_registry2/issues/103)) * [`4c130c9`](deitch/docker_registry2@4c130c9) Fix rubocop on master ([dependabot#102](https://redirect.github.com/deitch/docker_registry2/issues/102)) * See full diff in [compare view](deitch/docker_registry2@v1.18.0...v1.18.2)
…e fix also manually reported to Gemfile.lock files
Signed-off-by: Lewis Strong <lewis.strong@qodea.com>
@yeikel - Are you able to review this PR please? |
@lewis-strong I can't wait to see that being merged and released. 😄 |
does anyone knows how to get a dependabot maintainer to review PRs? |
@JamieMagee - I've rebased a number of times to keep the PR up to date, on the latest rebase though there's a check which appears to be hung and I can't cancel or rerun. Is this something you can help with? |
Rebased again and all checks passing again. Can we get this merged? @JamieMagee |
@lewis-strong Unfortunately, I don't have merge permissions in this repo. Let me see if I can get someone to merge. |
Thanks All! 🥳 |
Thank you guys! |
@lewis-strong this is causing errors. Might need to roll this back.
|
Thanks |
@JamieMagee was this an unrelated issue which has now been fixed? I can see Quay pagination is now working in dependabot and it's prompted me with an update this morning? |
What are you trying to accomplish?
Fix for pagination on quay.io as this is currently not working
#10347
https://github.com/deitch/docker_registry2/releases/tag/v1.18.2
Fix introduced at 1.18.2 as per above tag
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist