Revert "rework reporting of dependencies and requirements to better handle transitive dependencies" #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
077c870 to
a7b8ed0
Compare
a7b8ed0 to
15808ea
Compare
JamieMagee
approved these changes
Aug 21, 2024
…andle transitive dependencies" This reverts commit 75c0ab2.
999e976 to
491ec47
Compare
thavaahariharangit
approved these changes
Aug 22, 2024
491ec47 to
bd08177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## This PR contains a temporary commit to redirect the smoke tests. That temporary commit needs to be removed before merging.Corresponding smoke-tests PR that should go in at the same time: dependabot/smoke-tests#224
NuGet dependencies only exist via MSBuild and that allows arbitrary directory crawling. Due to the complexities of that, the previous PR #10449 is being reverted.
Future NuGet work will require rewriting the updater to not use any of the common dependabot code and that means the NuGet updater will be in a "broken" state for the time being and the previous version of "broken" is better than the current.