Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining dependabot core version constraint (latest_allowable_version) with existing composer version constraint #10150

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Jul 5, 2024

What are you trying to accomplish?

Combining both dependabot core version constraint and existing composer version constraint

Anything you want to highlight for special attention from reviewers?

Please let me know if there is any scenarios missed out on this PR.

How will you know you've accomplished your goal?

Ran Junit's and ensured that I am getting expected error message.

For ex:

 Your requirements could not be resolved to an installable set of packages.
         Problem 1
           - Root composer.json requires php-http/client-implementation ==6.0.0 ^1.0, it could not be found in any version, but the following packages provide it:
             - symfony/http-client Provides powerful methods to fetch HTTP resources synchronously or asynchronously

above test result shows, combination of both version constraints
ex:
==6.0.0 ^1.0
==6.0.0 - dependabot core version constraint
- space for intersection or and condition
^1.0 - composer constraint

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner July 5, 2024 13:32
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label Jul 5, 2024
@thavaahariharangit thavaahariharangit marked this pull request as draft July 5, 2024 13:32
@thavaahariharangit thavaahariharangit force-pushed the harry/convert_absolute_to_constraint_before_update_check branch from 2a4b7c5 to 79acb93 Compare July 6, 2024 20:10
@thavaahariharangit thavaahariharangit changed the title Converting absolute versions to constraints to check updates. Combining dependabot core version constraint (latest_allowable_version) with existing composer version constraint Jul 8, 2024
@thavaahariharangit thavaahariharangit marked this pull request as ready for review July 8, 2024 12:17
@thavaahariharangit thavaahariharangit merged commit ab3d8c1 into main Jul 9, 2024
56 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/convert_absolute_to_constraint_before_update_check branch July 9, 2024 11:22
@thesebas
Copy link

thesebas commented Jul 9, 2024

exactly at the moment when this was merged and since then I got new error on many projects:

Dependabot failed to update your dependencies because there was an error resolving your PHP dependency files.

Dependabot encountered the following error:

Could not parse version constraint == >= 2.1.0: Invalid version string ">= 2.1.0"

@thavaahariharangit
Copy link
Contributor Author

thavaahariharangit commented Jul 9, 2024

exactly at the moment when this was merged and since then I got new error on many projects:

Dependabot failed to update your dependencies because there was an error resolving your PHP dependency files.

Dependabot encountered the following error:

Could not parse version constraint == >= 2.1.0: Invalid version string ">= 2.1.0"

Thanks @thesebas

we have the solution for above in this #10176 - In Progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants