-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combining dependabot core version constraint (latest_allowable_version) with existing composer version constraint #10150
Merged
thavaahariharangit
merged 15 commits into
main
from
harry/convert_absolute_to_constraint_before_update_check
Jul 9, 2024
Merged
Combining dependabot core version constraint (latest_allowable_version) with existing composer version constraint #10150
thavaahariharangit
merged 15 commits into
main
from
harry/convert_absolute_to_constraint_before_update_check
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thavaahariharangit
force-pushed
the
harry/convert_absolute_to_constraint_before_update_check
branch
from
July 6, 2024 20:10
2a4b7c5
to
79acb93
Compare
…k' of https://github.com/dependabot/dependabot-core into harry/convert_absolute_to_constraint_before_update_check
thavaahariharangit
changed the title
Converting absolute versions to constraints to check updates.
Combining dependabot core version constraint (latest_allowable_version) with existing composer version constraint
Jul 8, 2024
robaiken
reviewed
Jul 8, 2024
robaiken
approved these changes
Jul 9, 2024
thavaahariharangit
deleted the
harry/convert_absolute_to_constraint_before_update_check
branch
July 9, 2024 11:22
exactly at the moment when this was merged and since then I got new error on many projects:
|
1 task
5 tasks
Thanks @thesebas we have the solution for above in this #10176 - In Progress |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Combining both dependabot core version constraint and existing composer version constraint
Anything you want to highlight for special attention from reviewers?
Please let me know if there is any scenarios missed out on this PR.
How will you know you've accomplished your goal?
Ran Junit's and ensured that I am getting expected error message.
For ex:
above test result shows, combination of both version constraints
- space for intersection or and condition
ex:
==6.0.0 ^1.0
==6.0.0
- dependabot core version constraint^1.0
- composer constraintChecklist