Add sane limit to PR description limit for Bitbucket cloud (#7693)

dependabot · Aug 2, 2023 · eece01f · eece01f
1 parent 6d642b9
commit eece01f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/common/lib/dependabot/pull_request_creator.rb b/common/lib/dependabot/pull_request_creator.rb
@@ -230,6 +230,8 @@ def message
         @pr_message_encoding = Azure::PR_DESCRIPTION_ENCODING if @pr_message_encoding.nil?
       when "codecommit"
         @pr_message_max_length = Codecommit::PR_DESCRIPTION_MAX_LENGTH if @pr_message_max_length.nil?
+      when "bitbucket"
+        @pr_message_max_length = Bitbucket::PR_DESCRIPTION_MAX_LENGTH if @pr_message_max_length.nil?
       end
 
       @message = MessageBuilder.new(

diff --git a/common/lib/dependabot/pull_request_creator/bitbucket.rb b/common/lib/dependabot/pull_request_creator/bitbucket.rb
@@ -10,6 +10,9 @@ class Bitbucket
                   :files, :commit_message, :pr_description, :pr_name,
                   :author_details, :labeler, :work_item
 
+      # BitBucket Cloud accepts > 1MB characters, but they display poorly in the UI, so limiting to 4x 65,536
+      PR_DESCRIPTION_MAX_LENGTH = 262_143 # 0 based count
+
       def initialize(source:, branch_name:, base_commit:, credentials:,
                      files:, commit_message:, pr_description:, pr_name:,
                      author_details:, labeler: nil, work_item: nil)