Merge pull request #11251 from dependabot/dev/brettfo/nuget-packages-…

…config-unauthorized expand pattern to report unauthorized feed
dependabot · Jan 8, 2025 · e45d543 · e45d543
2 parents 081474e + 4bf6898
commit e45d543
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/...elpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTests.PackagesConfig.cs b/...elpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTests.PackagesConfig.cs
@@ -2347,16 +2347,18 @@ public async Task MissingVisualStudioComponentTargetsAreReportedAsMissingFiles()
             Assert.Equal("$(MSBuildExtensionsPath32)/Microsoft/VisualStudio/v$(VisualStudioVersion)/Some.Visual.Studio.Component.props", result.ErrorDetails!.ToString().NormalizePathToUnix());
         }
 
-        [Fact]
-        public async Task ReportsPrivateSourceAuthenticationFailure()
+        [Theory]
+        [InlineData(401)]
+        [InlineData(403)]
+        public async Task ReportsPrivateSourceAuthenticationFailure(int httpStatusCode)
         {
-            static (int, string) TestHttpHandler(string uriString)
+            (int, string) TestHttpHandler(string uriString)
             {
                 var uri = new Uri(uriString, UriKind.Absolute);
                 var baseUrl = $"{uri.Scheme}://{uri.Host}:{uri.Port}";
                 return uri.PathAndQuery switch
                 {
-                    _ => (401, "{}"), // everything is unauthorized
+                    _ => (httpStatusCode, "{}"), // everything is unauthorized
                 };
             }
             using var http = TestHttpServer.CreateTestStringServer(TestHttpHandler);

diff --git a/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs b/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs
@@ -886,6 +886,7 @@ internal static void ThrowOnUnauthenticatedFeed(string stdout)
             "The plugin credential provider could not acquire credentials",
             "401 (Unauthorized)",
             "error NU1301: Unable to load the service index for source",
+            "Response status code does not indicate success: 403",
         };
         if (unauthorizedMessageSnippets.Any(stdout.Contains))
         {