TICtxtWrd-dcon: Test Improvements, Context Wording, ecosystem dev con…

…tainers and docker. (#9863)

Co-authored-by: “Thavachelvam <“thavaahariharangit@git.com”>

.rubocop_todo.yml

@@ -51,8 +51,6 @@ RSpec/BeforeAfterAll:
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Exclude:
-    - 'devcontainers/**/*'
-    - 'docker/**/*'
     - 'github_actions/**/*'
     - 'go_modules/**/*'
     - 'gradle/**/*'

devcontainers/spec/dependabot/devcontainers/update_checker_spec.rb

@@ -42,7 +42,7 @@
 
   let(:dependency) { dependencies.find { |dep| dep.name == name } }
 
-  shared_context "in root" do
+  shared_context "when the config is in root" do
     let(:project_name) { "config_in_root" }
     let(:directory) { "/" }
   end
@@ -53,13 +53,13 @@
     context "when feature is out-of-date" do
       let(:name) { "ghcr.io/codspace/versioning/foo" }
 
-      context "and config in root" do
-        include_context "in root"
+      context "when the config is in root" do
+        include_context "when the config is in root"
 
         it { is_expected.to be_falsey }
       end
 
-      context "and config in .devcontainer folder " do
+      context "when the config is in .devcontainer folder " do
         let(:project_name) { "config_in_dot_devcontainer_folder" }
         let(:directory) { "/.devcontainer" }
 
@@ -70,13 +70,13 @@
     context "when feature is already up-to-date" do
       let(:name) { "ghcr.io/codspace/versioning/bar" }
 
-      context "and config in root" do
-        include_context "in root"
+      context "when the config is in root" do
+        include_context "when the config is in root"
 
         it { is_expected.to be_truthy }
       end
 
-      context "and config in .devcontainer folder " do
+      context "when the config is in .devcontainer folder " do
         let(:project_name) { "config_in_dot_devcontainer_folder" }
         let(:directory) { "/.devcontainer" }
 
@@ -91,14 +91,14 @@
     let(:name) { "ghcr.io/codspace/versioning/foo" }
     let(:current_version) { "1.1.0" }
 
-    include_context "in root"
+    include_context "when the config is in root"
 
     context "when all later versions are being ignored" do
       let(:ignored_versions) { ["> #{current_version}"] }
 
       it { is_expected.to eq(current_version) }
 
-      context "raise_on_ignored" do
+      context "when raise_on_ignored is enabled" do
         let(:raise_on_ignored) { true }
 
         it "raises an error" do
@@ -112,7 +112,7 @@
 
       it { is_expected.to eq("2.0.0") }
 
-      context "raise_on_ignored" do
+      context "when raise_on_ignored is enabled" do
         let(:raise_on_ignored) { true }
 
         it { is_expected.to eq("2.0.0") }

docker/spec/dependabot/docker/file_fetcher_spec.rb

@@ -80,7 +80,7 @@
         .to match_array(%w(Dockerfile))
     end
 
-    context "that has an invalid encoding" do
+    context "when an invalid encoding is present" do
       let(:dockerfile_fixture) { fixture("github", "contents_image.json") }
 
       it "raises a helpful error" do
@@ -124,7 +124,7 @@
         .to match_array(%w(Dockerfile Dockerfile-base))
     end
 
-    context "one of which has an invalid encoding" do
+    context "when an invalid encoding is present" do
       let(:dockerfile_2_fixture) { fixture("github", "contents_image.json") }
 
       it "fetches the first Dockerfile, and ignores the invalid one" do
@@ -207,7 +207,7 @@
         .to match_array(%w(pod.yaml))
     end
 
-    context "that has an invalid encoding" do
+    context "when an invalid encoding is present" do
       let(:kubernetes_fixture) { fixture("github", "contents_image.json") }
 
       it "raises a helpful error" do
@@ -216,7 +216,7 @@
       end
     end
 
-    context "that has an non-kubernetes YAML" do
+    context "when an non-kubernetes YAML is present" do
       let(:kubernetes_fixture) { fixture("github", "contents_other_yaml.json") }
 
       it "raises a helpful error" do
@@ -260,7 +260,7 @@
         .to match_array(%w(deployment.yaml pod.yaml))
     end
 
-    context "one of which has an invalid encoding" do
+    context "when an invalid encoding is present" do
       let(:kubernetes_2_fixture) { fixture("github", "contents_image.json") }
 
       it "fetches the first yaml, and ignores the invalid one" do

docker/spec/dependabot/docker/file_parser_spec.rb

@@ -225,7 +225,7 @@
           .and_return(status: 200, body: registry_tags)
       end
 
-      context "that doesn't match any tags" do
+      context "when the digest doesn't match any tags" do
         let(:registry_tags) do
           fixture("docker", "registry_tags", "small_ubuntu.json")
         end
@@ -241,7 +241,7 @@
         its(:length) { is_expected.to eq(1) }
       end
 
-      context "that matches a tag" do
+      context "when the digest matches a tag" do
         before do
           stub_request(:head, repo_url + "manifests/10.04")
             .and_return(status: 404)
@@ -424,7 +424,7 @@
         end
       end
 
-      context "that are identical" do
+      context "when the lines are identical" do
         let(:dockerfile_fixture_name) { "multiple_identical" }
 
         its(:length) { is_expected.to eq(1) }
@@ -784,7 +784,7 @@
           .and_return(status: 200, body: registry_tags)
       end
 
-      context "that doesn't match any tags" do
+      context "when the digest doesn't match any tags" do
         let(:registry_tags) do
           fixture("docker", "registry_tags", "small_ubuntu.json")
         end
@@ -800,7 +800,7 @@
         its(:length) { is_expected.to eq(1) }
       end
 
-      context "that matches a tag" do
+      context "when the digest matches a tag" do
         before do
           stub_request(:head, repo_url + "manifests/10.04")
             .and_return(status: 404)
@@ -920,7 +920,7 @@
         end
       end
 
-      context "that are identical" do
+      context "when the lines are identical" do
         let(:podfile_fixture_name) { "multiple_identical.yaml" }
 
         its(:length) { is_expected.to eq(1) }

docker/spec/dependabot/docker/requirement_spec.rb

@@ -32,7 +32,7 @@
     let(:requirement_string) { "> 20.8.1.alpine3.18, < 20.9" }
 
     context "with a Dependabot::Docker::Version" do
-      context "for the current version" do
+      context "when using the current version" do
         let(:version) { Dependabot::Docker::Version.new("20.9.0-alpine3.18") }
 
         it { is_expected.to eq(false) }