Enable RSpec/ExcessiveDocstringSpacing (#9813)

* Enable RSpec/ExcessiveDocstringSpacing

* fixing new instances of ExcessiveDocstringSpacing

---------

Co-authored-by: Garry L Hurley Jr <166545206+GarryHurleyJr@users.noreply.github.com>

.rubocop_todo.yml

@@ -49,20 +49,6 @@ RSpec/ExampleWording:
     - 'updater/spec/dependabot/job_spec.rb'
     - 'updater/spec/dependabot/update_files_command_spec.rb'
 
-# Offense count: 14
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExcessiveDocstringSpacing:
-  Exclude:
-    - 'common/spec/dependabot/config/ignore_condition_spec.rb'
-    - 'common/spec/dependabot/file_parsers/base/dependency_set_spec.rb'
-    - 'common/spec/dependabot/shared_helpers_spec.rb'
-    - 'devcontainers/spec/dependabot/devcontainers/update_checker_spec.rb'
-    - 'go_modules/spec/dependabot/go_modules/update_checker_spec.rb'
-    - 'pub/spec/dependabot/pub/file_fetcher_spec.rb'
-    - 'pub/spec/dependabot/pub/update_checker_spec.rb'
-    - 'updater/spec/dependabot/file_fetcher_command_spec.rb'
-    - 'updater/spec/dependabot/updater_spec.rb'
-
 # Offense count: 17
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/ExpectActual:

common/spec/dependabot/config/ignore_condition_spec.rb

@@ -337,7 +337,7 @@ def expect_ignored(versions)
         let(:security_updates_only) { true }
         let(:update_types) { %w(version-update:semver-major version-update:semver-patch) }
 
-        it "allows all " do
+        it "allows all" do
           expect_allowed(patch_upgrades + minor_upgrades + major_upgrades)
         end
       end

common/spec/dependabot/file_parsers/base/dependency_set_spec.rb

@@ -224,7 +224,7 @@
     it { is_expected.to be_a(described_class) }
     its(:dependencies) { is_expected.to eq([dependency]) }
 
-    it "delegates to << " do
+    it "delegates to <<" do
       expect(dependency_set).to receive(:<<).with(dependency).and_call_original
       plus_dependencies
     end

common/spec/dependabot/shared_helpers_spec.rb

@@ -72,7 +72,7 @@ def existing_tmp_folders
     context "with a missing directory" do
       let(:directory) { "missing/directory" }
 
-      it "creates the missing directory " do
+      it "creates the missing directory" do
         expect(in_a_temporary_repo_directory)
           .to eq(Pathname.new(repo_contents_path).join(directory).to_s)
       end
@@ -87,7 +87,7 @@ def existing_tmp_folders
 
       let(:on_create) { -> { `stat some-file.txt 2>&1` } }
 
-      it "resets the changes " do
+      it "resets the changes" do
         expect(in_a_temporary_repo_directory)
           .to include("No such file or directory")
       end

devcontainers/spec/dependabot/devcontainers/update_checker_spec.rb

@@ -55,7 +55,7 @@
         it { is_expected.to be_falsey }
       end
 
-      context "when the config is in .devcontainer folder " do
+      context "when the config is in .devcontainer folder" do
         let(:project_name) { "config_in_dot_devcontainer_folder" }
         let(:directory) { "/.devcontainer" }
 
@@ -72,7 +72,7 @@
         it { is_expected.to be_truthy }
       end
 
-      context "when the config is in .devcontainer folder " do
+      context "when the config is in .devcontainer folder" do
         let(:project_name) { "config_in_dot_devcontainer_folder" }
         let(:directory) { "/.devcontainer" }
 

go_modules/spec/dependabot/go_modules/update_checker_spec.rb

@@ -132,7 +132,7 @@ module foobar
     context "when the current version is not vulnerable" do
       let(:dependency_version) { "1.0.0" }
 
-      it "raises an error " do
+      it "raises an error" do
         expect { lowest_resolvable_security_fix_version.to }.to raise_error(RuntimeError) do |error|
           expect(error.message).to eq("Dependency not vulnerable!")
         end

pub/spec/dependabot/pub/file_fetcher_spec.rb

@@ -27,7 +27,7 @@
   end
 
   context "with pubspec.yaml and pubspec.lock" do
-    it "fetches the  files" do
+    it "fetches the files" do
       expect(file_fetcher_instance.files.map(&:name))
         .to match_array(%w(pubspec.yaml pubspec.lock))
     end
@@ -37,7 +37,7 @@
     let(:project_name) { "mono_repo" }
     let(:directory) { "/main" }
 
-    it "fetches the  files" do
+    it "fetches the files" do
       expect(file_fetcher_instance.files.map(&:name))
         .to match_array(%w(pubspec.yaml pubspec.lock ../dep/pubspec.yaml))
     end
@@ -47,7 +47,7 @@
     let(:project_name) { "no_lockfile" }
     let(:directory) { "/main" }
 
-    it "fetches the  files" do
+    it "fetches the files" do
       expect(file_fetcher_instance.files.map(&:name))
         .to match_array(%w(pubspec.yaml ../dep/pubspec.yaml))
     end

pub/spec/dependabot/pub/update_checker_spec.rb

@@ -585,7 +585,7 @@
     context "when the current version is not newest but also not vulnerable" do
       let(:dependency_version) { "3.0.0" } # 3.1.0 is latest
 
-      it "raises an error " do
+      it "raises an error" do
         expect { lowest_resolvable_security_fix_version.to }.to raise_error(RuntimeError) do |error|
           expect(error.message).to eq("Dependency not vulnerable!")
         end

updater/spec/dependabot/file_fetcher_command_spec.rb

@@ -124,7 +124,7 @@
       end
     end
 
-    context "when the fetcher raises a file fetcher error (cloud) ", vcr: true do
+    context "when the fetcher raises a file fetcher error (cloud)", vcr: true do
       before do
         allow_any_instance_of(Dependabot::Bundler::FileFetcher)
           .to receive(:commit)
@@ -172,7 +172,7 @@
       end
     end
 
-    context "when the fetcher raises a file fetcher error (ghes) ", vcr: true do
+    context "when the fetcher raises a file fetcher error (ghes)", vcr: true do
       before do
         allow_any_instance_of(Dependabot::Bundler::FileFetcher)
           .to receive(:commit)

updater/spec/dependabot/updater_spec.rb

@@ -1462,7 +1462,7 @@ def expect_update_checker_with_ignored_versions(versions, dependency_matcher: an
       end
     end
 
-    context "when an unknown error is raised while updating dependencies (cloud) " do
+    context "when an unknown error is raised while updating dependencies (cloud)" do
       before do
         Dependabot::Experiments.register(:record_update_job_unknown_error, true)
       end