Migrate RecordPackageManagerVersion to RecordEcosystemVersions
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint was renamed in dependabot/dependabot-core#7517 and the accompanying internal API change. So the mock here needs updating. Also updated the struct.
3f6ceef to
cad6c54
Compare
bdragon
approved these changes
Jul 11, 2023
pavera
approved these changes
Jul 11, 2023
jeffwidman
added a commit
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the `PackageManager` field is replaced by the `EcosystemVersions` field. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
added a commit
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
added a commit
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
added a commit
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint was renamed in dependabot/dependabot-core#7517 and the accompanying internal API change.
So the mock here needs updating. Also updated the struct.
Note that the smoke tests will not pass until they are also updated... but we're in a chicken-and-egg because they currently blow up because this endpoint isn't mocked.