Api 12293 remove extra validations #9588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElleeB
reviewed
Apr 8, 2022
modules/appeals_api/spec/config/schemas/v1/200996_headers_json_spec.rb
Outdated
Show resolved
Hide resolved
ElleeB
reviewed
Apr 8, 2022
modules/appeals_api/spec/fixtures/v2/invalid_200996_headers_characters.json
Outdated
Show resolved
Hide resolved
ElleeB
reviewed
Apr 8, 2022
ElleeB
reviewed
Apr 11, 2022
modules/appeals_api/spec/requests/v2/higher_level_reviews_controller_spec.rb
Outdated
Show resolved
Hide resolved
ElleeB
reviewed
Apr 11, 2022
modules/appeals_api/spec/requests/v2/higher_level_reviews_controller_spec.rb
Show resolved
Hide resolved
ElleeB
reviewed
Apr 11, 2022
|
|
||
| context 'returns 422 when decison date is not a date' do | ||
| let(:error_content) do | ||
| { 'status' => 422, 'detail' => "'banana' did not fit within the defined length limits" } |
There was a problem hiding this comment.
Hm. Seems like the detail should be something like, "'banana' is not a date", or that it didn't match the pattern, right?
There was a problem hiding this comment.
Note: We're going to create a ticket to look into whether this is the expected detail.
ElleeB
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Look into the date validations across all three appeal types
Original issue(s)
API-12293
Things to Know About This PR
Question posed: can we validate that a date is in the past with the schemas?
Research Findings
It seems that many people have opened issues hoping for this feature, and as far as I can tell, they have all been closed for various reasons. A somewhat recent documentation states that json_)schema allows for time duration as part of the schema, but not a max value for a date.