refactor: The long awaited byte_type refactor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also optimizes the struct views to basically javascript object native performance, on my machine the reading the struct view is about ~4.2ns compared to ~3.9ns. Performance writing is about twice as good natively as compared to writing to a struct view. This should also apply to tuples! Co-authored-by: Dean Srebnik <load1n9@users.noreply.github.com>
|
I approve of this attractive pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planned
Deno.UnsafePointerViewand support forFFITypes which interoperate with the normalTypesOptimizations
This
commitpull request also optimizes the struct views to basically javascript object native performance, on my machine the reading the struct view is about ~4.2ns compared to ~3.9ns. Performance writing is about twice as good natively as compared to writing to a struct view. This should also apply to tuples!