Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tasks sidebar on config change notification #964

Merged

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #963. Coupled with denoland/deno#20827. The tasks sidebar will now only work with Deno 1.37.2 or whichever version that PR lands for, since it depends on the sourceUri being included in task definitions.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Curious; does this panel list both "tasks" from "deno.json" file as well as "scripts" from "package.json"? (That's what deno task does internally, adding a comment that certain script is from package.json).

@nayeemrmn
Copy link
Collaborator Author

does this panel list both "tasks" from "deno.json" file as well as "scripts" from "package.json"?

It doesn't apparently, we would patch that in main repo by including it in the deno/task response

@nayeemrmn nayeemrmn merged commit e660a88 into denoland:main Oct 11, 2023
@nayeemrmn nayeemrmn deleted the tasks-sidebar-refresh-on-config-change branch October 11, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task sidebar doesn't auto-update until before the next config file save
2 participants