Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "deno.internalInspect" setting #1007

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Coupled with denoland/deno#21482.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to mention - maybe we need to actually provide an address for this setting? When I was using that inspector yesterday I was getting panics in the editor because previous LSP instance was already bound. WDYT?

@nayeemrmn
Copy link
Collaborator Author

Sorry, I forgot to mention - maybe we need to actually provide an address for this setting? When I was using that inspector yesterday I was getting panics in the editor because previous LSP instance was already bound. WDYT?

Isn't there some allocation for those addresses in the CLI? Like if you launch two inspected process at once:
image

@bartlomieju
Copy link
Member

bartlomieju commented Dec 12, 2023

Sorry, I forgot to mention - maybe we need to actually provide an address for this setting? When I was using that inspector yesterday I was getting panics in the editor because previous LSP instance was already bound. WDYT?

Isn't there some allocation for those addresses in the CLI? Like if you launch two inspected process at once: image

Nope - for regular deno run you can provide the address in --inspect flags, for the LSP for now I hardcoded the address to 127.0.0.1:10101. Maybe we should look for a random free port in the CLI? But that's a bit problematic because chrome://inspect needs an allowlist of ports it can connect to. So random port won't show up an inspector on the list.

@nayeemrmn
Copy link
Collaborator Author

But in the screenshot I provided they have automatically hosted themselves on different pathnames on the same host/port, and there's no error. Though only the first one seems to be listed on devtools.

@bartlomieju
Copy link
Member

But in the screenshot I provided they have automatically hosted themselves on different pathnames on the same host/port, and there's no error. Though only the first one seems to be listed on devtools.

Oh I see what you mean. But if you have a Deno instance running with an inspector, then the LSP would try to bind to that port for inspector server. And that would still cause it to fail, because something is bound to that port.

@nayeemrmn nayeemrmn merged commit 69508d3 into denoland:main Dec 20, 2023
1 check passed
@nayeemrmn nayeemrmn deleted the internal-inspect-setting branch December 20, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants