Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): correct parsing of day period #6313

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

timreichen
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.43%. Comparing base (e3dc30a) to head (8c4eb2e).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
datetime/_date_time_formatter.ts 88.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6313      +/-   ##
==========================================
+ Coverage   96.35%   96.43%   +0.08%     
==========================================
  Files         547      547              
  Lines       41671    41788     +117     
  Branches     6315     6338      +23     
==========================================
+ Hits        40151    40298     +147     
+ Misses       1479     1449      -30     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title test(datetime): add token tests fix(datetime): correct handling of day periods handling Jan 10, 2025
@kt3k kt3k changed the title fix(datetime): correct handling of day periods handling fix(datetime): correct parsing of day period Jan 10, 2025
@kt3k
Copy link
Member

kt3k commented Jan 10, 2025

Note: This fixes the parsing of day periods veriants like AM. PM. A.M. P.M. (which was added in #5406, but wasn't working). Currently parse("A.M.", "a") throws. This branch fixes it.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 1ad8eab into denoland:main Jan 10, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants