Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fmt): handle missing group separator for 1000.1 in some locales #6117

Merged
merged 6 commits into from
Oct 23, 2024
Merged

test(fmt): handle missing group separator for 1000.1 in some locales #6117

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
295804f
fix(fmt): handle missing group separator for 1000.1 in some locales
IgorM867 Oct 14, 2024
4afc8b7
Merge branch 'main' into fix-fmt/bytes_test
IgorM867 Oct 15, 2024
e6a574e
Merge branch 'main' into fix-fmt/bytes_test
IgorM867 Oct 16, 2024
2b06d09
add test for group separators
IgorM867 Oct 16, 2024
4ad5309
Merge branch 'main' into fix-fmt/bytes_test
IgorM867 Oct 22, 2024
e74502b
Merge branch 'main' into fix-fmt/bytes_test
kt3k Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions fmt/bytes_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

import { format } from "./bytes.ts";
import { assertEquals, assertThrows } from "@std/assert";
import { stub } from "@std/testing/mock";

const parts = new Intl.NumberFormat().formatToParts(1000.1);
const parts = new Intl.NumberFormat().formatToParts(10000.1);
const decimal = parts.find(({ type }) => type === "decimal")!.value;
const group = parts.find(({ type }) => type === "group")!.value;

Deno.test("format() throws on invalid input", () => {
// deno-lint-ignore no-explicit-any
Expand Down Expand Up @@ -76,10 +76,6 @@ Deno.test("format() handles locale option", () => {
assertEquals(format(0.4, { locale: true }), `0${decimal}4 B`);
assertEquals(format(1001, { locale: true }), "1 kB");
assertEquals(format(10.1, { locale: true }), `10${decimal}1 B`);
assertEquals(
format(1e30, { locale: true }),
`1${group}000${group}000 YB`,
);

assertEquals(format(-0.4, { locale: false }), "-0.4 B");
assertEquals(format(0.4, { locale: false }), "0.4 B");
Expand All @@ -105,6 +101,41 @@ Deno.test("format() handles locale option", () => {
assertEquals(format(1e30, {}), "1000000 YB");
});

Deno.test("format() handles group separators", async (t) => {
const tests: { locale: string; expected: string }[] = [
{ locale: "en-US", expected: "1,000,000 YB" },
{ locale: "es-ES", expected: "1.000.000 YB" },

// narrow non-breaking space
{ locale: "fr-FR", expected: "1\u202f000\u202f000 YB" },

// non-breaking space
{ locale: "pl-PL", expected: "1\u00A0000\u00A0000 YB" },

// https://en.wikipedia.org/wiki/Indian_numbering_system
{ locale: "hi-IN", expected: "10,00,000 YB" },
{ locale: "gu-IN", expected: "10,00,000 YB" },
];

for (const { locale, expected } of tests) {
await t.step(locale, () => {
const toLocaleString = Number.prototype.toLocaleString;
using _ = stub(
Number.prototype,
"toLocaleString",
function (loc) {
return toLocaleString.call(this, loc ?? locale);
},
);

// explicitly supplying the locale
assertEquals(format(1e30, { locale }), expected);
// using the default locale (mocked with stub)
assertEquals(format(1e30, { locale: true }), expected);
});
}
});

Deno.test("format() handles signed option", () => {
assertEquals(format(42, { signed: true }), "+42 B");
assertEquals(format(-13, { signed: true }), "-13 B");
Expand Down