Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(json): fix typo #6103

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

softwarespot
Copy link
Contributor

@softwarespot softwarespot commented Oct 10, 2024

Found a small typo with checking if a string is blank.

@softwarespot softwarespot requested a review from kt3k as a code owner October 10, 2024 10:38
@github-actions github-actions bot added the json label Oct 10, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

@softwarespot softwarespot force-pushed the fix-json-is-blank-space-typo branch from b40667e to 6c526f5 Compare October 10, 2024 10:40
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (345e74f) to head (6c526f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6103   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         534      534           
  Lines       40589    40589           
  Branches     6093     6093           
=======================================
  Hits        39195    39195           
  Misses       1350     1350           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k changed the title fix(json): fix typo refactor(json): fix typo Oct 10, 2024
@kt3k kt3k merged commit a4cd8af into denoland:main Oct 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants