Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): simplify regexp type #5860

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 28, 2024 22:03
@github-actions github-actions bot added the yaml label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (0b59bfd) to head (39df983).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
yaml/_type/regexp.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5860   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files         479      479           
  Lines       38693    38682   -11     
  Branches     5628     5627    -1     
=======================================
- Hits        37267    37259    -8     
+ Misses       1382     1379    -3     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you'd be able to first write tests for this code? It's currently not covered.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that we have tests. Thank you.

@iuioiua iuioiua merged commit b7efc57 into denoland:main Aug 29, 2024
16 checks passed
@timreichen timreichen deleted the yaml-simplify-regexp-type branch August 29, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants