Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): inline readDoubleQuotedScalar() #5838

Merged

Conversation

timreichen
Copy link
Contributor

Ref: #5749

@timreichen timreichen requested a review from kt3k as a code owner August 27, 2024 08:10
@github-actions github-actions bot added the yaml label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.27%. Comparing base (7539060) to head (0591624).
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 92.06% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5838      +/-   ##
==========================================
- Coverage   96.27%   96.27%   -0.01%     
==========================================
  Files         479      479              
  Lines       38766    38764       -2     
  Branches     5623     5624       +1     
==========================================
- Hits        37321    37319       -2     
  Misses       1402     1402              
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit 2b66301 into denoland:main Aug 27, 2024
16 checks passed
@timreichen timreichen deleted the yaml-inline-readDoubleQuotedScalar branch August 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants